Skip to content

move Atmosphere to bevy_light #22709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
atlv24 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

move Atmosphere to bevy_light #22709

atlv24 wants to merge 3 commits into from

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 26, 2026

Objective

  • Another day, another step towards scene description outside of render crates

Solution

  • Move Atmosphere to bevy_light.

Testing

  • atmosphere example looks good.

@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 26, 2026
ecoskey
ecoskey approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@ecoskey ecoskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we needed this anyways to use ScatteringMedium with fog volumes. Two birds with one scone :)

@atlv24 atlv24 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 26, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mate-h mate-h mate-h approved these changes

@ecoskey ecoskey ecoskey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atlv24 @mate-h @ecoskey @alice-i-cecile